I scarcely saw “space emdash space” until LLMs were popularized. As an avid emdash user myself—and I’ve been doing it (perhaps improperly) for the last 25 years—the spaces are unnecessary and look bad.