A while back I was developing a workflow scheduler. However the run duration kept coming back negative. The runs kept finishing like 15 seconds before they started. Eventually I figured out why; the company had configured a policy to use their custom NTP server, but it was 16.7 seconds off. So my Windows laptop’s time was in the future, but the WSL VM (which ran the program) used another NTP server and was correct. In the end I just added a bodge that made the program request the time from an external server on startup to calculate an offset.

  • expletivedeleted@lemmy.zip
    link
    fedilink
    arrow-up
    0
    ·
    11 hours ago

    I was hired to work on a CMS designed for schools. I was tasked with debugging.

    I started off with the newest issues and worked my way back.

    Well, there was a bug where teachers would upload a video but it wouldn’t play on the page. It was plaguing a team of 8 for YEARS.

    It was mentioned in our morning standup, and I decided to fast track it.

    The dude who wrote the code was shrinking the display size in half: well how do you think that would work when a dimension of the video isn’t divisible by 2?

    So, remember, I am the new guy, quickly fixed it using an if/then and the % modulus operator, and lo and behold, the next morning standup I had to explain the fix in front of the project manager, his boss, and the entire team…

    fucking awkward. “You see, there’s this thing in division called a remainder.” This was the first thing in the morning.

    But because the bug had been so ever present, that’s why the boss’s boss attended the standup. God, I just wanted to die.

    • cristian64@reddthat.com
      link
      fedilink
      arrow-up
      0
      ·
      10 hours ago

      I don’t think I understand what the issue was or what the fix was. Was it a language or system that cannot perform the division with truncation?

      • expletivedeleted@lemmy.zip
        link
        fedilink
        arrow-up
        0
        ·
        9 hours ago

        Let’s say height and width are 320x214.

        (these numbers are arbitrarily chosen)

        The code was sizing it down by /2, so now it is 160 by 107.

        Because the width being odd, it would display.

        But:

        if ($width%2) { $width = --$width; }

        Hastily written out on the phone, but that was the fix. This was back with php 5.

          • bitfucker@programming.dev
            link
            fedilink
            arrow-up
            0
            ·
            2 hours ago

            For a strong typed language, an integer division should not cast to any other data type. Even assigning a float to an integer should not be allowed (that’s why C is not really strongly typed). I think from the syntax it was PHP. If any of the dimensions were not divisible by 2, then the number changed from integer to float and it could cause an issue somewhere downstream the video processing pipeline.

      • bss03@infosec.pub
        link
        fedilink
        English
        arrow-up
        0
        ·
        10 hours ago

        I think there are some versions of Python and/or PHP where the normal division operator silently promotes to IEEE floats, and you have to explicitly cast back to truncate/floor the value.